Styles for figure/figcaption on api.jquery.com #383
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
by the way, this shouldn't have any effect on the site as it is now. Will only affect new markup introduced in commit noted above. |
Member
|
I guess this is good, though we should probably wait for at least one entry to be updated to actually use a figure element. |
Member
Author
|
They're already there on staging. e.g. http://stage.api.jquery.com/click/ |
Member
|
Oh, in that case, let's merge! |
Member
|
Live on staging and production now. |
Member
Author
|
thanks, @scottgonzalez ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These styles are in preparation for a commit on api.jquery.com (see jquery/api.jquery.com#829)